[BUG] User doesn't get notification of a comment in a own post if no reactions involved

Erassus ︎ ︎ Posted in Technical Support 3 years ago

Steps:

User A: Create a public wall post in timeline.
User B: Replied the post of User A with a comment.
User A: Gets a notification for the comment, then the User A does a comment in the same post.
User B: Doesnt get notification of the comment of User A.

Tested with the .ova in vmware and in my production environment (feedback of my users)

Important note: No reactions involved.

Replies

Erassus ︎ ︎ Replied 3 years ago

I forgot to ask, if i want to fix that in my production environment, but i'm running php 7 and premium on, it won't work because i don't have php8, didn't?

Erassus ︎ ︎ Replied 3 years ago

@Arsalan and @Michael Thanks guys, i tested in my vm and now is working. Thanks again for the effort and patience !!

Arsalan Shah Replied 3 years ago

Glad to hear that :) It took few days for us to make it working lol

Michael Zülsdorff Replied 3 years ago

He Arsalan,
just replayed your steps with latest code: Working fine!
Groups working fine, too.
👍

Arsalan Shah Replied 3 years ago

Added a new pull and need help for testing though https://github.com/opensource-socialnetwork/opensource-socialnetwork/pull/2065

premium.informatikon.com

Created post AU1 -> AU2 (public post)
Commented from AU3 to the post above.
AU1 gets notification
AU2 gets notification

Then

AU2 commented on same post (ACU2)
AU1 Receives notification
AU3 Receives notification.

(Still not tested for groups yet)

Erassus ︎ ︎ Replied 3 years ago

Thanks, updated the line in the ossn_com.php and now works fine. No duplicated notifications.

Only issue left:

User A post in timeline of User B
User C (not friend of any) post first in the same post.
Only notification to User B

Note:

If the User C make another reply, two or three, still no notification to user A.

But if the user B reply before user C, it seems the notification will initialize and user A now will get all notifications from now.

enter image description here

Michael Zülsdorff Replied 3 years ago

Sorry, my first fix was ok for groups but had a side effect on user walls,
so the wall type needs to be checked first, see
https://github.com/opensource-socialnetwork/opensource-socialnetwork/pull/2063/commits/83cd1aead837785cd06d3576c90f66970b3d9cba

Erassus ︎ ︎ Replied 3 years ago

@Michael

Confirmed.

enter image description here

Regarding to other user replying, i'm facing strange behaviors, duplicated notifications.

enter image description here

Notifications x4 when only two comments.

enter image description here

my php installation:

enter image description here

I used the https://github.com/opensource-socialnetwork/opensource-socialnetwork/archive/refs/heads/v6.x.zip

Michael Zülsdorff Replied 3 years ago

Group wall issue should be fixed with
https://github.com/opensource-socialnetwork/opensource-socialnetwork/pull/2063/commits/4f55ed84a4de2d3b2ce203bb82d1596860676884

Please verify, if you like ... ;)

Erassus ︎ ︎ Replied 3 years ago

Hi Arsalan,

I agree with Michael and confirmed, tested in new fresh environment with php8 and only User B got the notification:

enter image description here

Group wall:

enter image description here

Premium Version

Due to the many requests in the past for additonal features and components we have decided to develope a premium version. Features like Hashtags, Videos, Polls, Events, Stories, Link Preview, etc included in it.