I think I got some of the scenarios solved so let me know what you think of 1.6. The tests all pass that failed earlier

Well this should be fun...

Yep, it'll be tricky. And: Have in mind you might run into names like Robert B. Meyer. 🤧

Got it, thanks for the explanation, I was way off track lol. I will have 1.6 uploaded tonight. The toughest part time wise after work will be to get the regex knocked out for the punctuation and line feeds. Im kind of thinking that a NOT a-Z0-9 kind of thing is going to be better than trying to list out invalid characters to trim off

You wrote:

   public function GetComments($subject, $type = 'post') {
                $vars                 = array();
                $vars['subject_guid'] = $subject;
                $vars['type']         = "comments:{$type}";

And I'm feeling a little puzzled. You aren't going to delete comment records, but notification records!

So after having another look: Why are you searching for notifications first at all in order to delete them as the next step?

When you delete a post, you KNOW the item_guid.
And if you look into the database, this id appears to be the subject_guid BOTH in notification records of type 'mention:post:created' AND mention:comment:created. So, to my opinion it would be sufficient to run simply 2 deletes like

$notifications->deleteNotification(array(
                    'type' =>'mention:post:created', 
                    'subject_guid' => $deleted_guid,
                   ));

and the same one with 'type' =>'mention:comment:created',

Hey one last question, Im not sure how the annotation response aligns to the notification payload. Here is the annotation response

                    "{$distinct}a.id", //no idea what this is from the db
                    'a.time_created', //dont need it
                    'a.owner_guid', // it has a match
                    'a.subject_guid', // it has a match
                    'a.type', // it has a match
                    'emd.value' // no idea what this is from the db

And here is the payload for the delete notification method

                'guid' // dont know what this matches to
                'type' // it has a match
                'poster_guid' // it does not have a match but I might not need this for comments
                'owner_guid' // it has a match
                'subject_guid' // it has a match
                'item_guid' // dont know what this matches to

Could you help me out understanding the mappings of these payloads?

Oh I just realized that may be a different type than I am thinking of.

Z,

Dude you are a rockstar. Its always tough to put your own code through all the right tests which is embarrassing for me because I was in QA for 2 years before I was qualified to do software development at my company lol. My bad and I will get those bugs fixed in v1.6.

I found an issue regarding collecting the comments on a deleted post that are mentions and just wanted to run this change by you. The problem is that the GetComments Method in the OssnComments class as shown below hard codes the word "comments:" to the beginning of the $type variable and my $type is "mention:comment:created" so I am thinking I just need to change that to be "comments:mention:created". What do you think of that?

public function GetComments($subject, $type = 'post') {
            $vars                 = array();
            $vars['subject_guid'] = $subject;
            $vars['type']         = "comments:{$type}";

Some bugs on mentioning I found so far ...:

Met @User Ten
and
@User Eleven later

only User Eleven gets notified

Met @User Ten first
and
@User Eleven later

both users get notified. => linefeeds directly after Username are causing issues

First met @User Ten. Later met @User Eleven.

nobody gets notified

Met @User Ten first. Met @User Eleven later.

both users get notified. => punctuation handling needs improvement

Hey Bryce,

I had a first look at 1.5 now. To start with the deleting part:

• delete User: ok
• delete Comment: ok
• delete Post: 'mention:post:created' records ok, but may leave orphan 'mention:comment:created' records. That is: it needs some extra code to loop through attached comments and check for mentions

Aside from that I would add a $deleted_guid = false; right in the beginning because it's a good practise not to rely on undefiend vars. Next, valid guids are guaranteed to be > 0, checking for >= is wrong. Simply change it if ($deleted_guid) {. Finally $user = new OssnUser; is obsolete (and gets overwritten on the next line anyway)